Re: [Xen-devel] [PATCH 5/6] xen/arm: Only enable physical IRQs when the guest asks

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 6 Dec 2013, Julien Grall wrote:
> On 12/06/2013 05:26 PM, Stefano Stabellini wrote:
> > From: Julien Grall <julien.grall@xxxxxxxxxx>
> > 
> > From: Julien Grall <julien.grall@xxxxxxxxxx>
> > 
> > Set/Unset IRQ_DISABLED from gic_irq_enable and gic_irq_disable.
> > Enable IRQs when the guest requests it, not unconditionally at boot time.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > ---
> 
> [..]
> 
> > @@ -605,6 +603,8 @@ int __init setup_dt_irq(const struct dt_irq *irq, struct
> > irqaction *new)
> > 
> >       rc = __setup_irq(desc, irq->irq, new);
> > 
> > +    desc->handler->startup(desc);
> > +
> 
> You forgot to take the GIC lock here.

You are right, the call to startup should be protected by the gic lock.
Interestingly the original code doesn't do that either.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel