Re: [Xen-devel] [PATCH] xen: arm: do not BUG on guest paddrs which are very high

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-12-06 at 16:05 +0000, Julien Grall wrote:
> > @@ -80,6 +81,8 @@ paddr_t p2m_lookup(struct domain *d, paddr_t paddr)
> >       spin_lock(&p2m->lock);
> >
> >       first = p2m_map_first(p2m, paddr);
> > +    if ( !first )
> > +        goto done;
> 
> If you jump to done, you will use pte which is uninitialized. Unlock the 
> spinlock should be enough here.

True. I wonder why the compiler didn't warn me about that, it's the sort
of thing it normally spots.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel