Re: [Xen-devel] [PATCH v7 2/2] libxl: spice usbredirection support for upstream qemu

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-12-03 at 17:13 +0000, Ian Jackson wrote:
> Fabio Fantoni writes ("[PATCH v7 2/2] libxl: spice usbredirection support for 
> upstream qemu"):
> > Usage: spiceusbredirection=NUMBER (default=0)
> ...
> > +=item B<spiceusbredirection=NUMBER>
> > +
> > +Enables spice usbredirection. Creates NUMBER usbredirection channels
> > +for redirection of up to 4 usb devices from spice client to domU's qemu.
> > +It requires an usb controller and if not defined it will automatically adds
> > +an usb2 controller. The default is disabled (0).
> 
> I see we have:
>   spice
>   spiceport
>   spicetls_port
>   spicehost
>   spicedisable_ticketing
>   spicepasswd
>   spiceagent_mouse
>   spicevdagent
>   spice_clipboard_sharing
> 
> This is a mess in terms of the spelling of the parameters.  But I
> guess the new one is with the majority.
> 
> The bulk of the patch seems fine.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> This needs a freeze exception.  George ?

Per the ensuing discussion I've now applied this on top of v8-iwj of
patch #1.

> 
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel