Re: [Xen-devel] [PATCH] libxenctrl: Fix xc_interface_close() crash if it gets NULL as an argument

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-12-03 at 12:58 +0100, Daniel Kiper wrote:
> On Tue, Dec 03, 2013 at 09:47:35AM +0000, Ian Campbell wrote:
> > On Mon, 2013-12-02 at 20:13 +0100, Daniel Kiper wrote:
> > > xc_interface_close() crashes if it gets NULL as an argument. However,
> > > it just calls xc_interface_close_common() which is called by many
> > > others functions. It means that they are also vulnerable. So fix above
> > > mentioned issue by adding NULL check in xc_interface_close_common().
> > > This way we fix similar issue in other functions which calls
> > > xc_interface_close_common() too.
> > >
> > > Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> >
> > I suppose this makes sense in the same way that free(NULL) does:
> >         Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Thanks.

And now applied.

> > Did you observe this with a particular caller?
> 
> Yes, I found this issue by chance in kaxec-tools. It is fixed

Great, thanks.

> right now but I agree that this type of functions should
> behave with NULL like free(NULL).
> 
> Daniel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel