Re: [Xen-devel] [PATCH] xen_disk: fix memory leak

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-12-04 at 11:35 +0000, Stefano Stabellini wrote:
> On Thu, 5 Dec 2013, Matthew Daley wrote:
> > On Thu, Dec 5, 2013 at 12:15 AM, Stefano Stabellini
> > <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > > On Wed, 4 Dec 2013, Matthew Daley wrote:
> > >> On ioreq_release the full ioreq was memset to 0, loosing all the data
> > >> and memory allocations inside the QEMUIOVector, which leads to a
> > >> memory leak. Create a new function to specifically reset ioreq.
> > >>
> > >> Reported-by: Maik Wessler <maik.wessler@xxxxxxxxx>
> > >> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> > >> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > >>
> > >> Backport to qemu-xen-unstable.
> > >>
> > >> Signed-off-by: Matthew Daley <mattd@xxxxxxxxxxx>
> > >
> > > This patch is already in qemu-xen-unstable:
> > >
> > > commit 90c96d33c41e243d5f2c6cc197779f5ab744879e
> > > Author: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> > > Date:   Mon Jan 14 18:26:53 2013 +0000
> > >
> > >     xen_disk: fix memory leak
> > 
> > Are you sure? I can only see that commit in qemu-upstream-unstable...
> 
> Right, sorry in xl we call qemu-upstream-unstable qemu-xen, so when I
> read qemu-xen-unstable I thought that you meant qemu-xen for unstable.
> Very confusing :S
> 
> To clarify: qemu-xen (repository named qemu-upstream-unstable) has the
> patch.
> qemu-xen-traditional (repository named qemu-xen-unstable) does not have
> the patch.

FWIW I was going to reply and suggest that the commit message say e.g.
        Backport to qemu-xen-traditional (qemu-xen-unstable.git)
but maybe this confusion only exists until it is committed

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel