Re: [Xen-devel] [PATCH v4 02/15] libxl: sanitize error handling in libxl_get_max_{cpus, nodes}

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-12-03 at 12:40 +0100, Dario Faggioli wrote:
> So, my view here is: if I modify the function, adding GC and the LOG()s,
> then it should also be moved, if not, it can stay where it is. What you
> seem to be suggesting is that I (either in this or a previous patch)
> move the function as is, for no apparent reason,

It's not for "no apparent reason", it is to separate code motion from
reworking the function, which you would explain in your commit message.

If that were considered no apparent reason then it wouldn't be possible
to split the code motion from the functional changes in the majority of
cases.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel