Re: [Xen-devel] [PATCH v5 12/17] xen/libxc: sched: DOMCTL_*vcpuaffinity works with hard and soft affinity

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.12.13 at 11:02, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
>>>> On 02.12.13 at 19:29, Dario Faggioli <dario.faggioli@xxxxxxxxxx> wrote:
>> +                goto setvcpuaffinity_out;
>> +
>> +            /*
>> +             * We both set a new affinity and report back to the caller what
>> +             * the scheduler will be effectively using.
>> +             */
>> +            if ( vcpuaff->flags & XEN_VCPUAFFINITY_HARD )
>> +            {
>> +                ret = xenctl_bitmap_to_bitmap(cpumask_bits(new_affinity),
>> +                                              &vcpuaff->cpumap_hard,
>> +                                              vcpuaff->cpumap_hard.nr_bits);
> 
> There's no code above range checking vcpuaff->cpumap_hard.nr_bits,
> yet xenctl_bitmap_to_bitmap() uses the passed in value to write into
> the array pointed to by the first argument. Why is this not
> xenctl_bitmap_to_cpumask() in the first place?

And just to make it explicit - with fundamental flaws like this, I'm
not certain anymore whether we really ought to rush this series
in for 4.4.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel