Re: [Xen-devel] [PATCH v2 5/6] arm32: enable PSCI secondary CPU bringup

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-12-02 at 12:08 +0100, Andre Przywara wrote:
> @@ -109,6 +110,9 @@ int __init platform_specific_mapping(struct domain *d)
>  #ifdef CONFIG_ARM_32
>  int __init platform_cpu_up(int cpu)
>  {
> +    if ( psci_available )
> +        return call_psci_cpu_on(cpu, init_secondary);
> +
>      if ( platform && platform->cpu_up )
>          return platform->cpu_up(cpu);
>  

Make me wonder why we don't either hardcode init_secondary in
call_psci_cpu_on or pass it as a parameter to cpu_up, but regardless:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

(FWIW if you were to change things, I'd be in favour of hardcoding on
the PSCI side)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel