Re: [Xen-devel] [PATCH] xenconsole: merge pty access check into when it is opened

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("Re: [Xen-devel] [PATCH] xenconsole: merge pty access 
check into when it is opened"):
> On 01/12/2013 23:14, Matthew Daley wrote:
> > On Mon, Dec 2, 2013 at 12:41 AM, Andrew Cooper
> > <andrew.cooper3@xxxxxxxxxx> wrote:
> >> access() can fail for many more reasons than just EACCES.  I would skip
> >> the errno check entirely and always print the error.
> > err() doesn't return though (calls exit()). Given that, is always
> > calling it still acceptable?
...
> Even as the patch currently stands, the behaviour of the loop has
> changed. Before, it would eat any error from access(), and only die in
> the toctou case where open() subsequently failed.

I had the impression there is sometimes a race during domain startup,
between a toolstack invoking xenconsole and xenconsoled allocating the
pty.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel