Re: [Xen-devel] [PATCH 00/13] Valgrind patches for hypercalls

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-11-28 at 18:56 +0000, Andrew Cooper wrote:
> This set of patches teaches valgrind about new hypercalls.
> 
> Valgrind can now completely inspect xc_domain_save()/restore()
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>

Thanks, these look OK to me on a quick skim and build so I've sent them
upstream to: https://bugs.kde.org/show_bug.cgi?id=328205

I also tacked on the following patch which 
        git diff RELEASE-4.3.0 -- xen/include/public/*ctl*
called out as the only interesting look new sys/domctl coming in 4.4

Ian.

commit 63230747f04a094a242e19b8c5c06eed773e56e3
Author: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date:   Fri Nov 29 11:43:18 2013 +0000

    xen: Implement XEN_DOMCTL_set_max_evtchn
    
    This is new in Xen 4.4.
    
    Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff --git a/coregrind/m_syswrap/syswrap-xen.c b/coregrind/m_syswrap/syswrap-xe
index 7561dda..02205da 100644
--- a/coregrind/m_syswrap/syswrap-xen.c
+++ b/coregrind/m_syswrap/syswrap-xen.c
@@ -759,6 +759,10 @@ PRE(domctl)
        }
        break;
 
+   case VKI_XEN_DOMCTL_set_max_evtchn:
+      PRE_XEN_DOMCTL_READ(set_max_evtchn, max_port);
+      break;
+
    default:
       bad_subop(tid, layout, arrghs, status, flags,
                 "__HYPERVISOR_domctl", domctl->cmd);
@@ -1149,6 +1153,7 @@ POST(domctl){
    case VKI_XEN_DOMCTL_set_cpuid:
    case VKI_XEN_DOMCTL_unpausedomain:
    case VKI_XEN_DOMCTL_sethvmcontext:
+   case VKI_XEN_DOMCTL_set_max_evtchn:
       /* No output fields */
       break;
 
diff --git a/include/vki/vki-xen-domctl.h b/include/vki/vki-xen-domctl.h
index 7cce4af..2d07f41 100644
--- a/include/vki/vki-xen-domctl.h
+++ b/include/vki/vki-xen-domctl.h
@@ -84,6 +84,7 @@
 #define VKI_XEN_DOMCTL_set_broken_page_p2m           67
 #define VKI_XEN_DOMCTL_setnodeaffinity               68
 #define VKI_XEN_DOMCTL_getnodeaffinity               69
+#define VKI_XEN_DOMCTL_set_max_evtchn                70
 #define VKI_XEN_DOMCTL_gdbsx_guestmemio            1000
 #define VKI_XEN_DOMCTL_gdbsx_pausevcpu             1001
 #define VKI_XEN_DOMCTL_gdbsx_unpausevcpu           1002
@@ -304,6 +305,10 @@ struct vki_xen_domctl_address_size {
     vki_uint32_t size;
 };
 
+struct vki_xen_domctl_set_max_evtchn {
+    vki_uint32_t max_port;
+};
+
 struct vki_xen_domctl {
     vki_uint32_t cmd;
     vki_uint32_t interface_version; /* XEN_DOMCTL_INTERFACE_VERSION */
@@ -359,6 +364,7 @@ struct vki_xen_domctl {
         //struct vki_xen_domctl_set_access_required access_required;
         //struct vki_xen_domctl_audit_p2m         audit_p2m;
         //struct vki_xen_domctl_set_virq_handler  set_virq_handler;
+        struct vki_xen_domctl_set_max_evtchn    set_max_evtchn;
         //struct vki_xen_domctl_gdbsx_memio       gdbsx_guest_memio;
         //struct vki_xen_domctl_set_broken_page_p2m set_broken_page_p2m;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel