Re: [Xen-devel] [PATCH 1/2] x86/vRTC: Make rtc_mode_{strict, no_ack} a per-domain option

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.11.13 at 21:39, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> +/* This forms an ABI in HVM_PARAM_RTC_MODE */

Irrespective of this ...

>  enum rtc_mode {
> -   rtc_mode_no_ack,
> -   rtc_mode_strict
> +   rtc_mode_no_ack = 0,
> +   rtc_mode_strict = 1

... this is a pointless change - the C specification requires them to
be 0 and 1 respectively. There would be a point to this only if you
added #define-s to the public interface (and used them here).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel