Re: [Xen-devel] [PATCH] xen/arm: Initial Broadcom A15 platform support

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-11-21 at 13:15 -0500, Jon Fraser wrote:
> On Mon, 2013-11-11 at 20:37 +0000, Julien Grall wrote:
> > On 11/08/2013 11:37 PM, Jon Fraser wrote:
> > > Initial platform support for Broadcom A15/B15 platforms.
> > >
> > > Signed-off-by: Jon Fraser <jfraser@xxxxxxxxxxxx>
> > 
> > Hello,
> > 
> > Thanks to add support for broadcom processor in Xen.
> > 
> > It seems you use the wrong coding style for this patch. You can read
> > CODING_STYLES at the root of the xen repository.
> 
> 
> Habits are hard to break!
> 
> Is there a xen equivalent of the linux checkpatch?

I'm afraid not.

> Or a set of command line options for indent that is acceptable
> to the xen community?

The closest is the emacs magic blocks at the bottom of most files, but
they only really cover the 4-space indentation and not all of the
whitespace differences etc. 

The bigs things are:
4 space indents
Spaces inside the if expre. eg. "if ( foo == bar )" not "if (foo ==
bar)"
The { comes on the next line not at the end so:
        if ( foo == bar )
        {
and not
        if ( foo == bar ) {
(similarly for while, for etc)

> Switching back and forth between xen and linux
> kernel,

Yeah, I do it all the time as well.

> I don't want to keep making formatting mistakes.  Well, I know
> I'll make them, I just want to catch them.
> 
> I'll address the rest of the issues and submit a new version
> as soon as I can.
> 
> Thanks,
> Jon
> 
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel