Re: [Xen-devel] [PATCH 10/16] xen: arm: enable synchronous console while starting secondary CPUs

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 11/20/2013 05:37 PM, Ian Campbell wrote:
> On Wed, 2013-11-20 at 17:31 +0000, Julien Grall wrote:
> > On 11/20/2013 02:48 PM, Ian Campbell wrote:
> > > If CONFIG_EARLY_PRINTK is in use then this gets all interleaved with the
> > > standard logging otherwise.
> > Before the discussion IRL, it was not clear to me that you want to
> > directly "flush" the console buffer when prinkt is called. Can you
> > improve your commit message?
> Sure. How about:
>
>          xen: arm: enable synchronous console while starting secondary
>          CPUs
>
>          Setting synchronous console ensures that any printk hits the
>          buffer immediately and that any outstanding queued log messages
>          are flushed. This ensures that such log messages are not being
>          printed while the secondary CPU may be using early_printk during
>          early bringup.
>
>          Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

This commit message looks better for me.

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel