Re: [Xen-devel] [PATCH] hvm: reset TSC to 0 after domain resume from S3

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.11.13 at 15:22, Tomasz Wroblewski <tomasz.wroblewski@xxxxxxxxxx> 
>>> wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -3736,8 +3736,13 @@ static void hvm_s3_suspend(struct domain *d)
>  
>  static void hvm_s3_resume(struct domain *d)
>  {
> +    struct vcpu *v;

Blank line needed here.

And it would imo be better to move the declaration inside the body
of the if().

>      if ( test_and_clear_bool(d->arch.hvm_domain.is_s3_suspended) )
> +    {
> +        for_each_vcpu( d, v )
> +            hvm_set_guest_tsc( v, 0 );

Stray blanks inside the parentheses.

(If I'm ending up committing this, and if no other need to redo
the patch shows up, I can take care of these cosmetics on the
fly, i.e. no need to send a v2 just for this.)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel