Re: [Xen-devel] TSC trouble in hvm linux, after host S3

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.11.13 at 12:55, Tomasz Wroblewski <tomasz.wroblewski@xxxxxxxxxx> 
>>> wrote:
> On 11/20/2013 12:51 PM, Jan Beulich wrote:
>>>>> On 20.11.13 at 12:41, Tomasz Wroblewski <tomasz.wroblewski@xxxxxxxxxx> 
>>>>> wrote:
>>> I've since found out that VMCS seems to provide tsc offsetting capabilities;
>>> adding something like
>>>
>>>           for_each_vcpu ( d, v )
>>>           {
>>>               if (v->vcpu_id == 0)
>>>                   hvm_set_guest_tsc(v, 0);
>>>           }
>>>
>>> inside hvm_s3_resume (xen/arch/x86/hvm/hvm.c) fixed this for me; any comment
>>> on such a solution?
>>
>> This sounds plausible, but I'd prefer it to be done alongside the other
>> state resetting done for S3 (which all happen in hvm_s3_suspend()).
>> Unless that doesn't work, of course.
>>
> All right, thanks! I'll try it out and post a patch, I think it should work. 
> I've only reset the tsc on vcpu 0 since I've noticed same is 
> done in hvm_vcpu_initialize(), is that enough?

Honestly I don't immediately see why it's being done there for
vCPU 0 only, and I don't think that's be sufficient for the resume
case.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel