Re: [Xen-devel] [PATCH v3 12/14] xl: enable getting and setting soft

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2013-11-18 at 19:18 +0100, Dario Faggioli wrote:
> Getting happens via `xl vcpu-list', which now looks like this:
> 
>  # xl vcpu-list -s
>  Name       ID VCPU CPU State Time(s) Hard Affinity / Soft Affinity
>  Domain-0   0     0  11  -b-     5.4  8-15 / all

Since the / is never likely to align, how about "CPU Affinity
(Hard/Soft)" as the title line?

>  Domain-0   0     1  11  -b-     1.0  8-15 / all
>  Domain-0   0    14  13  -b-     1.4  8-15 / all
>  Domain-0   0    15   8  -b-     1.6  8-15 / all
>  vm-test    3     0   4  -b-     2.5  0-12 / 0-7
>  vm-test    3     1   0  -b-     3.2  0-12 / 0-7
> 
> Setting happens by adding a '-s'/'--soft' switch to `xl vcpu-pin'.
> 
> xl manual page is updated accordingly.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> ---
> Changes from v2:
>  * this patch folds what in v2 were patches 13 and 14;
>  * `xl vcpu-pin' always shows both had and soft affinity,
>    without the need of passing '-s'.
> ---
>  docs/man/xl.pod.1         |   24 +++++++++++++++++++-
>  tools/libxl/xl_cmdimpl.c  |   54 
> +++++++++++++++++++++++----------------------
>  tools/libxl/xl_cmdtable.c |    3 ++-
>  3 files changed, 53 insertions(+), 28 deletions(-)
> 
> diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1
> index e7b9de2..481fbdf 100644
> --- a/docs/man/xl.pod.1
> +++ b/docs/man/xl.pod.1
> @@ -619,7 +619,7 @@ after B<vcpu-set>, go to B<SEE ALSO> section for 
> information.
>  Lists VCPU information for a specific domain.  If no domain is
>  specified, VCPU information for all domains will be provided.
>  
> -=item B<vcpu-pin> I<domain-id> I<vcpu> I<cpus>
> +=item B<vcpu-pin> [I<OPTIONS>] I<domain-id> I<vcpu> I<cpus>
>  
>  Pins the VCPU to only run on the specific CPUs.  The keyword
>  B<all> can be used to apply the I<cpus> list to all VCPUs in the
> @@ -630,6 +630,28 @@ different run state is appropriate.  Pinning can be used 
> to restrict
>  this, by ensuring certain VCPUs can only run on certain physical
>  CPUs.
>  
> +B<OPTIONS>
> +
> +=over 4
> +
> +=item B<-s>, B<--soft>
> +
> +The same as above, but affect I<soft affinity> rather than pinning
> +(also called I<hard affinity>).
> +
> +Normally, VCPUs just wander among the CPUs where it is allowed to
> +run (either all the CPUs or the ones to which it is pinned, as said
> +for B<vcpu-list>). Soft affinity offer a mean to specify one or more

I think "offers a means" is correct. Or perhaps "affinities offer a
means".

> +I<preferred> CPUs. Basically, among the ones where it can run, the
> +VCPU the VCPU will greately prefer to execute on one of these CPUs,

"greatly"

> diff --git a/tools/libxl/xl_cmdtable.c b/tools/libxl/xl_cmdtable.c
> index d3dcbf0..c97796f 100644
> --- a/tools/libxl/xl_cmdtable.c
> +++ b/tools/libxl/xl_cmdtable.c
> @@ -213,7 +213,8 @@ struct cmd_spec cmd_table[] = {
>      { "vcpu-pin",
>        &main_vcpupin, 1, 1,
>        "Set which CPUs a VCPU can use",
> -      "<Domain> <VCPU|all> <CPUs|all>",
> +      "[option] <Domain> <VCPU|all> <CPUs|all>",
> +      "-s, --soft         Deal with soft affinity",

"Set soft affinity" ? 

>      },
>      { "vcpu-set",
>        &main_vcpuset, 0, 1,
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel