Re: [Xen-devel] [Patch v4 2/5] x86/hpet: Use singe apic vector rather than irq_descs for HPET interrupts

[Tim Deegan <tim@xxxxxxx>]

Hi, 

This looks pretty good to me. 

At 17:59 +0000 on 13 Nov (1384361951), Andrew Cooper wrote:
> +        else if ( fallback_deadline < STIME_MAX && fallback_deadline != -1 )
> +        {
> +            /*
> +             * Else we want to reprogram the fallback HPET sooner if 
> possible,
> +             * but with all the spinlocking, it just might have passed.
> +             */
> +            ch = &hpet_events[fallback_idx];
> +
> +            spin_lock(&ch->lock);
>  
> -    if ( !(ch->flags & HPET_EVT_LEGACY) )
> -        hpet_attach_channel(cpu, ch);
> +            if ( ch->cpu != 1 && ch->next_event == fallback_deadline )

DYM '!= -1' here?

Apart from that, you can put 'Reviewed-by: Tim Deegan <tim@xxxxxxx>'
on patches 1-3.

Cheers,

Tim.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel