Re: [Xen-devel] [PATCH v3-RESEND 06/28] libxc: ocaml: add simple binding for xentoollog (output only).

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-10-21 at 14:32 +0100, Rob Hoes wrote:
> [...]

> +static void stub_xtl_ocaml_vmessage(struct xentoollog_logger *logger,
> +     xentoollog_level level,
> +     int errnoval,
> +     const char *context,
> +     const char *format,
> +     va_list al)
> +{
> +     CAMLparam0();
> +     CAMLlocalN(args, 4);
> +     struct caml_xtl *xtl = (struct caml_xtl*)logger;
> +     value *func = caml_named_value(xtl->vmessage_cb) ;
> +     char *msg;
> +
> +     if (args == NULL)
> +             caml_raise_out_of_memory();

Coverity is rightly pointing out that an array cannot be NULL. Would you
mind fixing as part of the resend of the remainder of this series?

[...]
> +static void stub_xtl_ocaml_progress(struct xentoollog_logger *logger,
> +     const char *context,
> +     const char *doing_what /* no \r,\n */,
> +     int percent, unsigned long done, unsigned long total)
> +{
> +     CAMLparam0();
> +     CAMLlocalN(args, 5);
> +     struct caml_xtl *xtl = (struct caml_xtl*)logger;
> +     value *func = caml_named_value(xtl->progress_cb) ;
> +
> +     if (args == NULL)
> +             caml_raise_out_of_memory();

Another one.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel