Re: [Xen-devel] [V1 PATCH 03/11] PVH dom0: iommu related changes

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.11.13 at 02:23, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -125,15 +125,27 @@ int iommu_domain_init(struct domain *d)
>      return hd->platform_ops->init(d);
>  }
>  
> +static inline void check_dom0_pvh_reqs(struct domain *d)

No point for this to be an inline function. Even more, irrespective
of whether it is, it should also be marked __init.

> @@ -141,12 +153,13 @@ void __init iommu_dom0_init(struct domain *d)
>          page_list_for_each ( page, &d->page_list )
>          {
>              unsigned long mfn = page_to_mfn(page);
> +            unsigned long gfn = mfn_to_gfn(d, _mfn(mfn));

So the other place in this file uses mfn_to_gmfn(), and I'd really like
two to remain in sync, so that things don't get even more confusing
(i.e. it's bad enough already that we have two almost identical
constructs).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel