Re: [Xen-devel] [RFC 5/8] x86/msi: Refactor msi_compose_message() to not requrie an irq_desc

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.11.13 at 19:54, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/include/asm-x86/msi.h
> +++ b/xen/include/asm-x86/msi.h
> @@ -231,7 +231,7 @@ struct arch_msix {
>  };
>  
>  void early_msi_init(void);
> -void msi_compose_msg(struct irq_desc *, struct msi_msg *);
> +void msi_compose_msg(unsigned vector, const cpumask_t *mask, struct msi_msg 
> *);

Please be consistent here - either re-add a name for the last
parameter, or drop the name of the middle one. Reviewed-by
with that change.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel