[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1 of 5 V3] remus: add libnl3 dependency to autoconf scripts

On Sun, 2013-10-20 at 22:58 -0700, Shriram Rajagopalan wrote:
> diff -r 808aba98084e -r 357655a1598c tools/configure.ac
> --- a/tools/configure.ac      Fri Oct 11 18:16:11 2013 -0700
> +++ b/tools/configure.ac      Fri Oct 11 18:16:21 2013 -0700
> @@ -219,6 +219,24 @@ AC_SUBST(libiconv)
>  # Checks for header files.
>  AC_CHECK_HEADERS([yajl/yajl_version.h sys/eventfd.h])
> +# Check for libnl3 >=3.2.8. If present enable remus network buffering.
> +PKG_CHECK_MODULES(LIBNL3, [libnl-3.0 >= 3.2.8 libnl-route-3.0 >= 3.2.8],
> +             [libnl3_lib="y"], [libnl3_lib="n"])
> +
> +# Check for libnl3 command line utilities

These cli utils are needed on the runtime host but not the build host,
right? (for the benefit of the hotplug scripts I suppose?)

This check only runs on the build host, so it will fail needlessly if
the tools aren't there while at the same time not catching the case
where they are missing from the runtime host.

Best bet is to omit this check and simply list them in the README, in
the list of optional tools (and reference tools/remus/README for more
info if you like).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.