Re: [Xen-devel] [PATCH] xen/arm: UART addresses are not always aligned to a page.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-10-30 at 11:57 -0700, Julien Grall wrote:
> On 28 October 2013 18:28, Jon Fraser <jfraser@xxxxxxxxxxxx> wrote:
> >          /* Map the DTB in the boot misc slot */
> > diff --git a/xen/include/asm-arm/asm_defns.h 
> > b/xen/include/asm-arm/asm_defns.h
> > index 36e72ff..5bcaa44 100644
> > --- a/xen/include/asm-arm/asm_defns.h
> > +++ b/xen/include/asm-arm/asm_defns.h
> > @@ -7,6 +7,9 @@
> >  #endif
> >  #include <asm/processor.h>
> >
> > +/* Offset in page of UART base address */
> > +#define UART_OFFSET (EARLY_UART_BASE_ADDRESS & ~PAGE_MASK)
> > +
> 
> Actually I would move this define in asm/early-printk.h. It's the best place.
> Can you also rename the name to EARLY_UART_OFFSET?
> 
> In order to avoid numerous FIXMAP(CONSOLE) + UART_OFFSET, is it
> possible to create a define EARLY_UART_VIRTUAL_ADDRESS and use it
> everywhere?

I agree with all 3 suggestions here.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel