Re: [Xen-devel] [PATCH] improve the error message in "xl list --long"

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Oct 28, 2013 at 04:22:20PM +0000, Ian Jackson wrote:
> Wei Liu writes ("Re: [Xen-devel] [PATCH] improve the error message in "xl 
> list --long""):
> > On Mon, Oct 28, 2013 at 03:19:36PM +0000, Ian Jackson wrote:
> > > Wei Liu writes ("Re: [Xen-devel] [PATCH] improve the error message in "xl 
> > > list --long""):
> > > > Another posibility is that Xen fails to clean up a domain after its
> > > > death. That domain remains visible in Xen, however at that time the
> > > > stored config file is already deleted.
> > > > 
> > > > IMHO we can skip this domain without printing this info. Or this info
> > > > needs to cover all the situations.
> > > 
> > > I think for now (that is, until we can reconstruct the domain config
> > > from the running state) we should not skip the domain, but instead
> > > simply not include the missing info in the long output.
> > 
> > TBH I'm confused... You seemed to agree to skip in another patch.
> > <21094.40745.754203.842615@xxxxxxxxxxxxxxxxxxxxxxxx>
> 
> Yes, sorry, but, I think I was wrong earlier.
> 
> I don't think missing an existing domain out of the listing can be
> right.  That would make it just appear to vanish!
> 

Rereading your earlier comment.

"we should not skip the domain, but instead not include the missing info
in the long output"

This is what <21094.40745.754203.842615@xxxxxxxxxxxxxxxxxxxxxxxx> and
this patch does -- only that this patch prints one more line to info
user the situation. The problem I'm seeing with this patch is that the
info doesn't seem to cover all the cases.

This patch and the one I proposed skips zero-length domain in long
output. You can still see the domain in short output -- it doesn't
vanish. :-)

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel