Re: [Xen-devel] [PATCH] xl: don't emit misleading daemon pid message

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Matthew Daley writes ("[PATCH] xl: don't emit misleading daemon pid message"):
> After creating a domain, xl forks off a process to handle domain events
> (shutdown, disk eject, ...). It prints out the pid of the process
> created by the fork to stdout. However, the newly forked process soon
> after calls daemon(), which itself forks once more (and exit()s the
> original process). This means that the pid printed out is not the pid of
> the actual process which remains in the background after all is said and
> done, instead it is the pid of the transient process that exists between
> xl's fork() and the fork'd process's daemon() call.
> 
> We could resolve this by printing the correct pid, ie. by open-coding
> daemon() (we already do most of the heavy lifting it does ourselves by
> fiddling with the standard fds). However, since no-one seems to be
> complaining about the misleading message to begin with, and since it
> seems like a pointless message anyway, just remove it outright instead.
> 
> Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx>

Thanks,
Ian.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel