Re: [Xen-devel] [PATCH v3-RESEND 03/28] libxl: ocaml: avoid reserved words in type and field names.

[Rob Hoes <Rob.Hoes@xxxxxxxxxx>]

On 24 Oct 2013, at 23:04, Ian Campbell <ian.campbell@xxxxxxxxxx>
 wrote:

> On Mon, 2013-10-21 at 14:32 +0100, Rob Hoes wrote:
>> Do this by adding a "xl_" prefix to all names.
> 
> Does this not result in pretty fugly looking ocaml code with lots of
> spurious "xl_" everywhere?

Yes… I'm not too happy about that, but I think it is the only easy enough way 
of making this transformation "injective", as IanJ suggested. The alternative 
would be to change the munge function on a case-by-case basis, e.g. whenever 
someone adds a name which happens to be an OCaml keyword to the libxl IDL.

>> 
>> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> Signed-off-by: Rob Hoes <rob.hoes@xxxxxxxxxx>
>> 
>> ---
>> New in v3:
>> * Using common prefixes rather than changing names on a case by case basis.
>> ---
>> tools/ocaml/libs/xl/genwrap.py |    5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>> 
>> diff --git a/tools/ocaml/libs/xl/genwrap.py b/tools/ocaml/libs/xl/genwrap.py
>> index 1b68b6b..a14fcfe 100644
>> --- a/tools/ocaml/libs/xl/genwrap.py
>> +++ b/tools/ocaml/libs/xl/genwrap.py
>> @@ -70,8 +70,11 @@ def ocaml_type_of(ty):
>>     else:
>>         return ty.rawname
>> 
>> +def munge_name(name):
>> +    return "xl_" + name
>> +
>> def ocaml_instance_of(type, name):
>> -    return "%s : %s" % (name, ocaml_type_of(type))
>> +    return "%s : %s" % (munge_name(name), ocaml_type_of(type))
>> 
>> def gen_ocaml_ml(ty, interface, indent=""):
>> 
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel