[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] Nested VMX: CR emulation fix up

>>> "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx> 10/24/13 3:14 AM >>>
>Jan Beulich wrote on 2013-10-24:
>>>>> Yang Zhang <yang.z.zhang@xxxxxxxxx> 10/23/13 9:20 AM >>>
>>> Acked-by: "Dong, Eddie" <eddie.dong@xxxxxxxxx>
>> I don't think this can be counted as ack - neither do I recall having
>> seen this ack on the list, nor did you Cc Eddie (I specifically did not 
>> alter the Cc list here), i.e.
>> he would also have no way to communicate his objection to this.
>He already acked the first version. Please have a double check or check the 
>attached mail (in case of his mail only send to our internal mailbox).

But you see, this is again a process problem of yours: You sent a v2 without
information on what changed from v1. And I hope you don't expect me to go back
and compare the two versions. Hence I have to assume there were substantial
changes that made it not worth pointing them out individually, and I think it's 
to you that substantial changes always invalidate any earlier acks/reviews (the
same would imo go for eventual bugs fixed that the person having given the ack/
review overlooked).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.