Re: [Xen-devel] [PATCH] pygrub: Support (/dev/xvda) style disk specifications

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH] pygrub: Support (/dev/xvda) style disk 
specifications"):
> You get these if you install Debian Wheezy as HVM and then try to convert to
> PV.
> 
> This is Debian bug #603391.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Tested-by: Tril <tril@xxxxxxxxxxxx>

...
> -        self._disk = int(val[2:])
> +        if val.startswith("/dev/xvd"):
> +            disk = val[len("/dev/xvd")]
> +            self._disk = ord(disk)-ord('a')
> +        else:
> +            self._disk = int(val[2:])
>      disk = property(get_disk, set_disk)

Cor, the existing code is quite a hack here, isn't it ?

Nevertheless, your change looks good to me.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel