Re: [Xen-devel] [PATCH 04/16] xen/events: replace raw bit ops with functions

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 10/08/2013 08:49 AM, David Vrabel wrote:
> From: Wei Liu <wei.liu2@xxxxxxxxxx>
>
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
>   drivers/xen/events.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index 359e983..fec5da4 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -1548,13 +1548,12 @@ static int set_affinity_irq(struct irq_data *data, 
> const struct cpumask *dest,
>   static int retrigger_evtchn(int evtchn)
>   {
>         int masked;
> -       struct shared_info *s = HYPERVISOR_shared_info;
>   
>   	if (!VALID_EVTCHN(evtchn))
>                 return 0;
>   
>   	masked = test_and_set_mask(evtchn);
> -       sync_set_bit(evtchn, BM(s->evtchn_pending));
> +       set_evtchn(evtchn);
>         if (!masked)
>                 unmask_evtchn(evtchn);
There are other places in this file that manipulate evtchn_pending bits 
(e.g. in unmask_evtchn()). As long as this change is made, those places 
should probably be updated as well.
You also need a commit message for this and previous patch.

-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel