Re: [Xen-devel] [xen-unstable test] 19756: regressions - trouble: broken/fail/pass

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-10-11 at 12:29 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [xen-unstable test] 19756: regressions 
> - trouble: broken/fail/pass"):
> > I have suppressed:
> > 2013-09-19 23:03:42 Z LEAKED [file /tmp/xm-deprecation-long-warning] file: 
> > 399061    0 -rw-r--r--   1 root     root            0 Sep 19 23:58 
> > /tmp/xm-deprecation-long-warning
> 
> Wait, what ?  I assume this is a stamp file to prevent repeated
> issuance of the warning ?
> 
> It should definitely not be in /tmp.  /var/run I think.

Yes, quite right.

This will need an osstest change to whitelist the new path.

8>--------------------

From 1ba08526200e44317a63ee3e15c05a702bb15bd8 Mon Sep 17 00:00:00 2001
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Fri, 11 Oct 2013 12:49:05 +0100
Subject: [PATCH] xend: Drop long deprecation warning in /var/run not /tmp

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 tools/python/xen/xm/xm |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/python/xen/xm/xm b/tools/python/xen/xm/xm
index 6a3f545..fef4272 100755
--- a/tools/python/xen/xm/xm
+++ b/tools/python/xen/xm/xm
@@ -6,7 +6,7 @@ from xen.xm import main
 
 print >>sys.stderr, ("WARNING: xend/xm is deprecated.")
 
-if not os.path.exists("/tmp/xm-deprecation-long-warning"):
+if not os.path.exists("/var/run/xm-deprecation-long-warning"):
     print >>sys.stderr, ("""
 xend is deprecated and scheduled for removal. Please migrate to another
 toolstack ASAP.
@@ -15,6 +15,6 @@ See http://wiki.xen.org/wiki/Choice_of_Toolstacks for 
information on
 other alternatives, including xl which is designed to be a drop in
 replacement for xm (http://wiki.xen.org/wiki/XL).
 """)
-    open("/tmp/xm-deprecation-long-warning", "w").close()
+    open("/var/run/xm-deprecation-long-warning", "w").close()
 
 main.main(sys.argv)
-- 
1.7.10.4




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel