[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [xen] double fault: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC

On Thu, Oct 10, 2013 at 03:23:45AM +0100, Dave Airlie wrote:
> > I think David Arlie also needs a quiet talking to about how to use the
> > device model:
> > 
> > int drm_sysfs_device_add(struct drm_minor *minor)
> > {
> >         minor->kdev.release = drm_sysfs_device_release;
> > ...
> >         err = device_register(&minor->kdev);
> > }
> > 
> > static void drm_sysfs_device_release(struct device *dev)
> > {
> >         memset(dev, 0, sizeof(struct device));
> >         return;
> > }
> > 
> > Since when has that been acceptable in a release function?
> Well the commit that added it had a reason that seems to cover some other 
> device model abuses, so maybe someone who actually understands the device 
> model (all 2 people) can review usage.

Please - there's more than two people who understand this stuff.

You appear to manage to understand the refcounting principle for things
like the DRM framebuffers, DRM buffer objects etc, and the driver model
(and kobjects in general) are no different.

I've just been reading the code around here little more, and hit the usb
implementation.  I don't see how USB drivers get cleaned up when they're
disconnected from the USB bus.  I see drm_unplug_dev() which gets called
on a USB disconnection (from udl/udl_drv.c) which effectively makes the
device unavailable, but I don't see anything which frees anything.  I see
nothing calling drm_put_dev() here.  How does the drm_device in this case
get freed?

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.