Re: [Xen-devel] [Patch] hvm/vidirian: Avoid printing page_to_mfn(NULL) on error paths.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.10.13 at 22:17, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/viridian.c
> +++ b/xen/arch/x86/hvm/viridian.c
> @@ -157,7 +157,7 @@ static void enable_hypercall_page(struct domain *d)
>          if ( page )
>              put_page(page);
>          gdprintk(XENLOG_WARNING, "Bad GMFN %lx (MFN %lx)\n", gmfn,
> -                 page_to_mfn(page));
> +                 page ? page_to_mfn(page) : ~0UL);
>          return;
>      }
>  
> @@ -202,7 +202,7 @@ static void initialize_apic_assist(struct vcpu *v)
>          if ( page )
>              put_page(page);
>          gdprintk(XENLOG_WARNING, "Bad GMFN %lx (MFN %lx)\n", gmfn,
> -                 page_to_mfn(page));
> +                 page ? page_to_mfn(page) : ~0UL);
>          return;
>      }
>  

So why did you not use INVALID_MFN here, other than you had
suggested earlier?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel