Re: [Xen-devel] [PATCH v6 5/5] xen: introduce XENMEM_pin

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 30 Sep 2013, Tim Deegan wrote:
> > > > +        {
> > > > +            rc = -EINVAL;
> > > > +            goto fail;
> > > > +        }
> > > > +
> > > > +        rc = guest_physmap_pin_range(d, gpfn, pin.in.extent_order);
> > > > +        if ( rc )
> > > > +            goto fail;
> > > > +
> > > > +        for ( j = 0; j < (1UL << pin.in.extent_order); j++ )
> > > > +        {
> > > > +            mfn = gmfn_to_mfn(d, gpfn);
> > > 
> > > I'm afraid you didn't even build test this on x86: There's no
> > > gmfn_to_mfn() there.
> > 
> > Argh. On x86 I'll call get_gfn_unshare and ASSERT that the page is not
> > shared (guest_physmap_pin_range is not implemented on x86 but it should
> > have definitely unshared the page or failed doing so).
> 
> On x86 can you not just ENOSYS the whole thing?
 
Yeah, I guess it makes sense, but it requires an #ifdef in common code.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel