Re: [Xen-devel] [PATCH 10/13] xen/events: Refactor evtchn_to_irq array to be dynamically allocated

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Thu, Sep 26, 2013 at 11:53:07AM +0100, David Vrabel wrote:
> On 24/09/13 15:58, Konrad Rzeszutek Wilk wrote:
> > On Fri, Sep 13, 2013 at 05:59:58PM +0100, David Vrabel wrote:
> >> From: Malcolm Crossley <malcolm.crossley@xxxxxxxxxx>
> >>
> >> Refactor static array evtchn_to_irq array to be dynamically allocated by
> >> implementing get and set functions for accesses to the array.
> >>
> >> Two new port ops are added: max_channels (maximum supported number of
> >> event channels) and nr_channels (number of currently usable event
> >> channels).  For the N-level ABI, these numbers are both the same as
> >> the shared data structure is a fixed size. For the FIFO ABI, these
> >                             ^^ has
> 
> I think either usage is fine.
> 
> >> +  if (evtchn_to_irq[row] == NULL) {
> >> +          /* Unallocated irq entries return -1 anyway */
> >                                            ^^^^^ - are
> 
> Unallocated entries can't have a value because they're, well,
> unallocated. So I think the original phrasing is more correct.

But right after that you have 'return 0;' which threw me out.
> 
> "get_evtchn_to_irq() returns -1 for unallocated entries anyway" would be
> slighter better though.

That would do it too.
> 
> David
> 
> ps. Can you also trim your replies in future?  As in between the grammar
> nit-picking there was an actual bug that needed fixing and this is hard
> to find with the untrimmed quoting.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel