Re: [Xen-devel] [PATCH RFC 08/12] libxl: don't launch Qemu on Dom0 for Qdisk devices on driver domains

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-09-23 at 12:30 +0200, Roger Pau Monne wrote:
> In libxl__need_xenpv_qemu check that the backend domain of the Qdisk
> device is Dom0 before launching a Qemu instance in the toolstack
> domain.

Should the check not be disks[i].backend == domid from the function you
added in patch #1?

> 
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  tools/libxl/libxl_dm.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 4035b6d..ddc7367 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -1368,7 +1368,8 @@ int libxl__need_xenpv_qemu(libxl__gc *gc,
>  
>      if (nr_disks > 0) {
>          for (i = 0; i < nr_disks; i++) {
> -            if (disks[i].backend == LIBXL_DISK_BACKEND_QDISK) {
> +            if (disks[i].backend == LIBXL_DISK_BACKEND_QDISK &&
> +                disks[i].backend_domid == LIBXL_TOOLSTACK_DOMID) {
>                  ret = 1;
>                  goto out;
>              }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel