Re: [Xen-devel] [PATCH RFC 02/12] libxl: remove unneeded libxl_domain_info in wait_device_connection

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-09-23 at 12:30 +0200, Roger Pau Monne wrote:
> The info fetched by libxl_domain_info is not used anywere in the
> function.
> 
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  tools/libxl/libxl_device.c |   10 ----------
>  1 files changed, 0 insertions(+), 10 deletions(-)
> 
> diff --git a/tools/libxl/libxl_device.c b/tools/libxl/libxl_device.c
> index 16a92a4..2971dd3 100644
> --- a/tools/libxl/libxl_device.c
> +++ b/tools/libxl/libxl_device.c
> @@ -715,16 +715,8 @@ void libxl__wait_device_connection(libxl__egc *egc, 
> libxl__ao_device *aodev)
>      STATE_AO_GC(aodev->ao);
>      char *be_path = libxl__device_backend_path(gc, aodev->dev);
>      char *state_path = libxl__sprintf(gc, "%s/state", be_path);
> -    libxl_dominfo info;
> -    uint32_t domid = aodev->dev->domid;
>      int rc = 0;
>  
> -    libxl_dominfo_init(&info);
> -    rc = libxl_domain_info(CTX, &info, domid);
> -    if (rc) {
> -        LOG(ERROR, "unable to get info for domain %d", domid);
> -        goto out;
> -    }
>      if (QEMU_BACKEND(aodev->dev)) {
>          /*
>           * If Qemu is not running, there's no point in waiting for
> @@ -746,12 +738,10 @@ void libxl__wait_device_connection(libxl__egc *egc, 
> libxl__ao_device *aodev)
>          goto out;
>      }
>  
> -    libxl_dominfo_dispose(&info);
>      return;
>  
>  out:
>      aodev->rc = rc;
> -    libxl_dominfo_dispose(&info);
>      device_hotplug_done(egc, aodev);
>      return;
>  }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel