Re: [Xen-devel] [PATCH 12/13] xen/events: Add the hypervisor interface for the FIFO-based event channels

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Tue, Sep 24, 2013 at 05:11:54PM +0100, David Vrabel wrote:
> On 24/09/2013 16:08, Konrad Rzeszutek Wilk wrote:
> >> +/*
> >> + * FIFO ABI
> >> + */
> >> +
> >> +/* Events may have priorities from 0 (highest) to 15 (lowest). */
> >> +#define EVTCHN_FIFO_PRIORITY_MIN     15
> >> +#define EVTCHN_FIFO_PRIORITY_DEFAULT 7
> >> +
> >> +#define EVTCHN_FIFO_MAX_QUEUES (EVTCHN_FIFO_PRIORITY_MIN + 1)
> >> +
> >> +typedef uint32_t event_word_t;
> > 
> > Typedefs are frowed upon in the Linux kernel. Can you just use uint32_t
> > please?
> 
> Checkpatch frowned at this too but I just frowned back.  I think this
> specific typedef improves maintainability so I'm not inclined to remove
> it to satisfy an arbitrary rule.

<laughs>

<laughs some more>

typedefs it is then.
> 
> David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel