Re: [Xen-devel] [PATCH 11/13] xen/events: add xen_evtchn_mask_all()

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Fri, Sep 13, 2013 at 05:59:59PM +0100, David Vrabel wrote:
> From: David Vrabel <david.vrabel@xxxxxxxxxx>
> 
> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
>  drivers/xen/events/events.c |   18 ++++++++++++------
>  1 files changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/xen/events/events.c b/drivers/xen/events/events.c
> index 8660459..6c55b1f 100644
> --- a/drivers/xen/events/events.c
> +++ b/drivers/xen/events/events.c
> @@ -331,6 +331,14 @@ static void bind_evtchn_to_cpu(unsigned int chn, 
> unsigned int cpu)
>       info->cpu = cpu;
>  }
>  
> +static void xen_evtchn_mask_all(void)
> +{
> +     unsigned evtchn;
> +
> +     for (evtchn = 0; evtchn < xen_evtchn_nr_channels(); evtchn++)
> +             mask_evtchn(evtchn);
> +}
> +
>  /**
>   * notify_remote_via_irq - send event to remote end of event channel via irq
>   * @irq: irq of event channel to send event to
> @@ -1505,12 +1513,11 @@ EXPORT_SYMBOL_GPL(xen_test_irq_shared);
>  
>  void xen_irq_resume(void)
>  {
> -     unsigned int cpu, evtchn;
> +     unsigned int cpu;
>       struct irq_info *info;
>  
>       /* New event-channel space is not 'live' yet. */
> -     for (evtchn = 0; evtchn < xen_evtchn_nr_channels(); evtchn++)
> -             mask_evtchn(evtchn);
> +     xen_evtchn_mask_all();
>  
>       /* No IRQ <-> event-channel mappings. */
>       list_for_each_entry(info, &xen_irq_list_head, list)
> @@ -1609,7 +1616,7 @@ void xen_callback_vector(void) {}
>  
>  void __init xen_init_IRQ(void)
>  {
> -     int i;
> +     int ret;
>  
>       xen_evtchn_init_nlevel();
>  
> @@ -1618,8 +1625,7 @@ void __init xen_init_IRQ(void)
>       BUG_ON(!evtchn_to_irq);
>  
>       /* No event channels are 'live' right now. */
> -     for (i = 0; i < xen_evtchn_nr_channels(); i++)
> -             mask_evtchn(i);
> +     xen_evtchn_mask_all();
>  
>       pirq_needs_eoi = pirq_needs_eoi_flag;
>  
> -- 
> 1.7.2.5
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel