Re: [Xen-devel] [PATCH] ns16550: Use correct #define symbol for HAS_IOPORTS

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-09-23 at 18:25 +0100, Andrew Cooper wrote:
> CID 1091471, Regression caused by 7c1de0038895cbc75ebd0caffc5b0f3f03c5ad51
> 
> This appears to be a typo which causes check_existence() to unconditionally
> return 1 in all cases.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Keir Frser <keir@xxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  xen/drivers/char/ns16550.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
> index 5892eb7..9c2cded 100644
> --- a/xen/drivers/char/ns16550.c
> +++ b/xen/drivers/char/ns16550.c
> @@ -503,7 +503,7 @@ static int __init check_existence(struct ns16550 *uart)
>  {
>      unsigned char status, scratch, scratch2, scratch3;
>  
> -#ifdef HAS_IO_PORTS
> +#ifdef HAS_IOPORTS
>      /*
>       * We can't poke MMIO UARTs until they get I/O remapped later. Assume 
> that
>       * if we're getting MMIO UARTs, the arch code knows what it's doing.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel