Re: [Xen-devel] [PATCH 1/2] xen: add LZ4 decompression support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.09.13 at 17:00, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Mon, 2013-09-23 at 15:54 +0100, Jan Beulich wrote:
>> Add support for LZ4 decompression in Xen. LZ4 Decompression APIs for
>> Xen are based on LZ4 implementation by Yann Collet.
>> 
>> Benchmark Results(PATCH v3)
>> Compiler: Linaro ARM gcc 4.6.2
>> 
>> 1. ARMv7, 1.5GHz based board
>> [...]
>> 2. ARMv7, 1.7GHz based board
> 
> BTW Xen doesn't use these decompressors on ARM, the kernel self extracts
> in guest context. I see you aren't adding this to the ARM build anyway,
> just thought I'd explain ;-)

Yeah, I just copied the Linux commit message mostly verbatim.

>> Russell King said that we should have:
>> 
>>  - one decompressor which is the fastest
>>  - one decompressor for the highest compression ratio
>>  - one popular decompressor (eg conventional gzip)
>> 
>> If we have a replacement one for one of these, then it should do exactly
>> that: replace it.
> 
> What a shame this logic doesn't apply to Xen's use too since we need to
> support old kernels :-(

And they didn't rip out the LZO one either...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel