Re: [Xen-devel] [PATCH RFC 5/7] xen: arm: rewrite start of day page table and cpu bring up

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2013-09-18 at 14:57 +0100, Julien Grall wrote:
> > +static int vexpress_cpu_up(int cpu)
> > +{
> > +    static int have_set_sysflags = 0;
> > +
> > +    /* XXX separate init hook? */
> > +    if ( !have_set_sysflags )
> > +    {
> > +        void __iomem *sysflags;
> > +
> > +        sysflags = ioremap_nocache(V2M_SYS_MMIO_BASE, PAGE_SIZE);
> 
> The device should contains a node with compatible "arm,vexpress-sysreg".
> Can you use this node instead of hardcoding value?

It doesn't seem to be in the dts's which are designed for use with the
fast-models (git://linux-arm.org/arm-dts.git).

In any case this code is already conditional on running on a vexpress
platform. Making the vexpress support more complete/dynamic is a nice to
have but not really a blocker IMHO.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel