[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 5/5] xl: test script for the cpumap parser (for vCPU pinning)



On mer, 2013-09-11 at 10:49 +0100, Ian Campbell wrote:
> On Tue, 2013-09-10 at 18:52 +0100, Ian Jackson wrote:
> > Dario Faggioli writes ("[PATCH v2 5/5] xl: test script for the cpumap 
> > parser (for vCPU pinning)"):
> > > This commit introduces "check-xl-vcpupin-parse" for helping
> > > verifying and debugging the (v)CPU bitmap parsing code in xl.
> > > 
> > > The script runs "xl -N vcpu-pin 0 all <some strings>"
> > > repeatedly, with various input strings, and checks that the
> > > output is as expected.
> [...]
> > I think it would be better, TBH, if you separated out the test
> > generation from the execution.  check-xl-vif-parse et al have the test
> > data as an annex to the harness material, but you could have it in a
> > separate file which you could have a script to generate.
> 
> Support for testing specific strings which have been reported as buggy
> in the past would be useful too.
> 
Done in v3 (just posted) via passing a "-s <string>" option to the
script.

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.