Re: [Xen-devel] [PATCH v2 5/6] libxc: introduce xc_map_domain_meminfo (and xc_unmap_domain_meminfo)

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On ven, 2013-09-13 at 13:05 +0100, Ian Campbell wrote:
> On Tue, 2013-09-10 at 19:54 +0200, Dario Faggioli wrote:
> > +static inline xen_pfn_t pfn_to_mfn(xen_pfn_t pfn, xen_pfn_t *p2m, int 
> > gwidth)
> > +{
> > +  return ((xen_pfn_t) ((gwidth==8)?
> > +                       (((uint64_t *)p2m)[(pfn)]):
> > +                       ((((uint32_t *)p2m)[(pfn)]) == 0xffffffffU ?
> > +                            (-1UL) :
> > +                            (((uint32_t *)p2m)[(pfn)]))));
> > +}
> > +
> 
> OMG. (since it's just moved no need to fix, but I couldn't let it pass).
> 
:-D

It is pure code motion, so I did not touch it, but I'm up for trying to
refactor it a bit.

Will do in next version or, if the series gets in as is, in a follow up
patch, ok?

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel