Re: [Xen-devel] [PATCH 2/9] passthrough/amd: Drop unnecessary lock lookup.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.09.13 at 14:15, Tim Deegan <tim@xxxxxxx> wrote:
> The lock's not used for anything, and AFAICT no locking is needed
> since the IVRS tables are static after boot.
> 
> Coverity CID 1087199
> 
> Signed-off-by: Tim Deegan <tim@xxxxxxx>

That was an oversight of mine I think.

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

> --- a/xen/drivers/passthrough/amd/iommu_intr.c
> +++ b/xen/drivers/passthrough/amd/iommu_intr.c
> @@ -443,7 +443,6 @@ static int update_intremap_entry_from_msi_msg(
>       * devices.
>       */
>  
> -    lock = get_intremap_lock(iommu->seg, alias_id);
>      if ( ( req_id != alias_id ) &&
>           get_ivrs_mappings(iommu->seg)[alias_id].intremap_table != NULL )
>      {
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx 
> http://lists.xen.org/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel