Re: [Xen-devel] [PATCH v2-resend 04/30] libxl: idl: complete some enums in the IDL with their defaults

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-08-27 at 15:56 +0100, Ian Jackson wrote:
> Rob Hoes writes ("[Xen-devel] [PATCH v2-resend 04/30] libxl: idl: complete 
> some enums in the IDL with their defaults"):
> > There are several enums in the IDL that are initialised to 0, while
> > the value 0 is not part of the enum itself. This creates problems for
> > language bindings generated from the IDL, such as the OCaml ones.
> > 
> > Added an explicit (0, "UNKNOWN") enum value where appropriate, or used
> > init_val to default to a sensible value.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Applied.

> 
> (I haven't double checked each of these changes against the context,
> but the principle is sound.)
> 
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel