Re: [Xen-devel] [PATCH V1 22/29] xen/arm: Create a fake timer node in dom0 device tree

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 09/09/2013 12:51 PM, Ian Campbell wrote:
> On Wed, 2013-08-28 at 15:47 +0100, Julien Grall wrote:
> [...]
>> +    static const struct dt_device_match timer_ids[] __initconst =
>> +    {
>> +        DT_MATCH_COMPATIBLE("arm,armv7-timer"),
>> +        DT_MATCH_COMPATIBLE("arm,armv8-timer"),
>> +        { /* sentinel */ },
>> +    };
> [...]
>> @@ -588,6 +649,8 @@ static int handle_node(struct domain *d, struct 
>> kernel_info *kinfo,
>>          DT_MATCH_COMPATIBLE("arm,psci"),
>>          DT_MATCH_PATH("/cpus"),
>>          DT_MATCH_COMPATIBLE("arm,cortex-a15-gic"),
>> +        DT_MATCH_COMPATIBLE("arm,armv7-timer"),
>> +        DT_MATCH_COMPATIBLE("arm,armv8-timer"),
> 
> Both of these now need to be kept in sync with time.c. Can we find a
> better way?

What about the same solution as for the GIC?

#define TIMER_COMPATIBLE                   \
  DT_MATCH_COMPATIBLE("arm,armv7-timer"),  \
  DT_MATCH_COMPATIBLE("arm,armv8-timer")

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel