Re: [Xen-devel] [PATCH V1 23/29] xen/arm: Add new platform specific callback device_is_blacklist

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-08-28 at 15:47 +0100, Julien Grall wrote:
> Each platform code will list the device that must not pass-through to a guest.
> Theses devices are used for: power management, timer,...
> 
> When theses devices are given to DOM0, it can controls the hardware and then
> break the whole platform.
> 
> This callback is enough until we will start to care about power performance.
> For this purpose, we may need to extend this interface to implement per-device
> MMIO filtering to allow dom0 to continue to control devices which it owns 
> which
> happen to share e.g. a clock controller with Xen.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> ---
>     Changes in v2:
>         - Update commit message
> ---
>  xen/arch/arm/domain_build.c    |    2 +-
>  xen/arch/arm/platform.c        |   10 ++++++++++
>  xen/include/asm-arm/platform.h |    7 +++++++
>  3 files changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 3afe48f..1ac261e 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -663,7 +663,7 @@ static int handle_node(struct domain *d, struct 
> kernel_info *kinfo,
>      DPRINT("handle %s\n", path);
>  
>      /* Skip theses nodes and the sub-nodes */
> -    if ( dt_match_node(skip_matches, np ) )
> +    if ( dt_match_node(skip_matches, np ) || 
> platform_device_is_blacklist(np) )

Should be "blacklisted". Other than that:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel