Re: [Xen-devel] [PATCH] xen/balloon: remove BUG_ON in increase_reservation

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 5 Sep 2013, Wei Liu wrote:
> The BUG_ON in increase_reservation is wrong as we have P2M entry
> ballooned out page set to balloon scratch page, so it might have a valid
> P2M entry at that point.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>


>  drivers/xen/balloon.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
> index 3101cf6..b52df76 100644
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -349,8 +349,6 @@ static enum bp_state increase_reservation(unsigned long 
> nr_pages)
>               BUG_ON(page == NULL);
>  
>               pfn = page_to_pfn(page);
> -             BUG_ON(!xen_feature(XENFEAT_auto_translated_physmap) &&
> -                    phys_to_machine_mapping_valid(pfn));
>  
>               set_phys_to_machine(pfn, frame_list[i]);
>  
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel