Re: [Xen-devel] [PATCH] x86: remove references to unimplemented BIOS reboot option

[Matt Wilson <msw@xxxxxxxxx>]

On Fri, Aug 30, 2013 at 09:53:21AM +0100, Jan Beulich wrote:
> >>> On 30.08.13 at 02:13, Matt Wilson <msw@xxxxxxxxxx> wrote:
> > The BIOS reboot option was never implemented for x86_64, and retaining
> > it is somewhat false advertising.
> 
> Applied, but ...
> 
> > @@ -128,7 +124,7 @@ static int __init override_reboot(struct dmi_system_id 
> > *d)
> >  static struct dmi_system_id __initdata reboot_dmi_table[] = {
> >      {    /* Handle problems with rebooting on Dell E520's */
> >          .callback = override_reboot,
> > -        .driver_data = (void *)(long)BOOT_BIOS,
> > +        .driver_data = (void *)(long)BOOT_KBD,
> >          .ident = "Dell E520",
> >          .matches = {
> >              DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),

[...]

> > @@ -277,7 +273,7 @@ static struct dmi_system_id __initdata 
> > reboot_dmi_table[] = {
> >      },
> >      {    /* Handle problems with rebooting on ASUS P4S800 */
> >          .callback = override_reboot,
> > -        .driver_data = (void *)(long)BOOT_BIOS,
> > +        .driver_data = (void *)(long)BOOT_KBD,
> >          .ident = "ASUS P4S800",
> >          .matches = {
> >              DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
> 
> ... I guess quite a few of these entries are obsolete too.

I spot checked a few and they supported x86_64. I didn't really want
to dig into every one, so I figured we'd just leave it for now.

--msw

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel