Xen project Mailing List

Re: [Xen-devel] [PATCH] x86: remove references to unimplemented BIOS reboot option

From: "Jan Beulich" <JBeulich@xxxxxxxx>

Date: Fri, 30 Aug 2013 09:53:21 +0100

Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ben Guthro <benjamin.guthro@xxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx

Delivery-date: Fri, 30 Aug 2013 08:53:35 +0000

List-id: Xen developer discussion <xen-devel.lists.xen.org>

>>> On 30.08.13 at 02:13, Matt Wilson <msw@xxxxxxxxxx> wrote: > The BIOS reboot option was never implemented for x86_64, and retaining > it is somewhat false advertising. Applied, but ... > @@ -128,7 +124,7 @@ static int __init override_reboot(struct dmi_system_id *d) > static struct dmi_system_id __initdata reboot_dmi_table[] = { > { /* Handle problems with rebooting on Dell E520's */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Dell E520", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > @@ -137,7 +133,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on Dell 1300's */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Dell PowerEdge 1300", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"), > @@ -146,7 +142,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on Dell 300's */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Dell PowerEdge 300", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"), > @@ -155,7 +151,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on Dell Optiplex 745's SFF */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Dell OptiPlex 745", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > @@ -164,7 +160,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on Dell Optiplex 745's DFF */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Dell OptiPlex 745", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > @@ -174,7 +170,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on Dell Optiplex 745 with 0KW626 > */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Dell OptiPlex 745", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > @@ -184,7 +180,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on Dell Optiplex 330 with 0KP561 > */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Dell OptiPlex 330", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > @@ -194,7 +190,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on Dell Optiplex 360 with 0T656F > */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Dell OptiPlex 360", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > @@ -204,7 +200,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on Dell OptiPlex 760 with 0G919G > */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Dell OptiPlex 760", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > @@ -214,7 +210,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on Dell 2400's */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Dell PowerEdge 2400", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"), > @@ -223,7 +219,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on Dell T5400's */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Dell Precision T5400", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > @@ -232,7 +228,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on Dell T7400's */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Dell Precision T7400", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > @@ -241,7 +237,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on HP laptops */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "HP Compaq Laptop", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > @@ -250,7 +246,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on Dell XPS710 */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Dell XPS710", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > @@ -259,7 +255,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on Dell DXP061 */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Dell DXP061", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > @@ -268,7 +264,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on Sony VGN-Z540N */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "Sony VGN-Z540N", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"), > @@ -277,7 +273,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] > = { > }, > { /* Handle problems with rebooting on ASUS P4S800 */ > .callback = override_reboot, > - .driver_data = (void *)(long)BOOT_BIOS, > + .driver_data = (void *)(long)BOOT_KBD, > .ident = "ASUS P4S800", > .matches = { > DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."), ... I guess quite a few of these entries are obsolete too. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.