Re: [Xen-devel] [PATCH] EFI: fix tool chain capabilities detection

[Tim Deegan <tim@xxxxxxx>]

At 14:55 +0100 on 26 Aug (1377528920), Jan Beulich wrote:
> Commit f5a54e92 ("xen: move some arch CFLAGS into the common Rules.mk")
> transformed CFLAGS assignments to CFLAGS-y ones, which collides with
> the was xen/arch/x86/efi/Makefile determines whether the tol chain is
> usable for an EFI build. Transform the block back to using CFLAGS.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Eurgh, that difference between CFLAGS and CFLAGS-y should at least be
documented somewhere so anyone adding a new flag knows what to do.

But this patch looks fine anyway.  Reviewed-by: Tim Deegan <tim@xxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel